Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5029: CTAs should initialize in dark mode preference #1251

Merged
merged 15 commits into from
Sep 27, 2024
Merged

Conversation

mayaraman19
Copy link
Collaborator

@mayaraman19 mayaraman19 commented Sep 23, 2024

Stories/Links:

DOP-5029

Updates Banner.js and CTABanner.js.

Current Behavior:

CTA Banner
App Services Deprecation

Staging Links:

CTA Banner
Test Banner Page
App Services Deprecation

Notes:

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for mongodb-snooty ready!

Name Link
🔨 Latest commit 38ff579
🔍 Latest deploy log https://app.netlify.com/sites/mongodb-snooty/deploys/66f6c2cd451f1900080c34c7
😎 Deploy Preview https://deploy-preview-1251--mongodb-snooty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really does look great. Okay, I know this is so annoying, but since we're doing this anyway - could you also do the :before: and the svg so that those colors don't flash in light mode too?
And there's one odd thing happening... in the first link, the "You are" initialize in dark blue... I'm somehow guessing it's because of the anchor tag, but I really am not sure!

@biancalaube
Copy link
Collaborator

biancalaube commented Sep 24, 2024

Hey Maya, I noticed 3 small things in the that maybe could be fixed but Im not sure if they are blockers or not


  1. CTA Banner : I noticed that the text “You can” on refresh goes from dark blue to the respective color for dark/light mode. I noticed it also flashes the dark blue in light mode.
  2. I noticed for just regular banners ( Test Banner Page ) that the left handside background color still flashes light mode before going to dark mode.
  3. On the App Services Deprecation page the size of the font changes on reload. I don’t really know if that needs to be a fix in this ticket but just something I thought would be good to point out.

Update: I noticed Matt also commented on the 1st point so you can ignore that one.

@mayaraman19 mayaraman19 changed the title DOP-5029 DOP-5029: CTAs should initialize in dark mode preference Sep 25, 2024
@mayaraman19
Copy link
Collaborator Author

mayaraman19 commented Sep 26, 2024

@biancalaube the behavior seems to happen in preprd as well, so I'm going to file a ticket for this! edit: nvm seung just filed one

@biancalaube
Copy link
Collaborator

Thanks for doing that Maya, LGTM! :)

Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh so beautiful

@mayaraman19 mayaraman19 merged commit 6943a0a into main Sep 27, 2024
8 checks passed
@mayaraman19 mayaraman19 deleted the DOP-5029 branch September 27, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants