Updates tools/test README
#2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSonOfThomp
requested review from
shaneeza
and removed request for
a team
|
shaneeza
reviewed
Sep 16, 2024
| To do this manually, first run the [init script](./scripts/install-react17.ts) in order to install the specific testing dependencies needed for React 17. (`yarn init17` from the repo root) | ||
|
|
||
| ```bash | ||
| > yarn init17 |
There was a problem hiding this comment.
to exit react17 mode, would we run yarn?
There was a problem hiding this comment.
I think you need to clean first, but yeah. I'll add that
shaneeza
approved these changes
Sep 16, 2024
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to README:
Testing in React 17
In CI we test our components using React 17.
To do this manually, first run the init script in order to install the specific testing dependencies needed for React 17. (
yarn init17from the repo root)> yarn init17Next, run your tests with the
--react17flag. This ensures that the tests are run with specific Jest config for React 17.To go back to the default version of React you'll need to clear your packages and re-build: