LG-4516: deprecate justify="fit" from popover and related components #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15e4bd0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stephl3
requested review from
a team and
tsck
and removed request for
a team
|
Size Change: -361 B (-0.03%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
tsck
reviewed
Sep 13, 2024
| @@ -63,7 +63,7 @@ The popover component will be automatically positioned relative to its nearest p | |||
| | ------------------ | ---------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | ---------- | | |||
| | `active` | `boolean` | Determines whether the Popover is active or inactive | `false` | | |||
| | `align` | `'top'` \| `'bottom'` \| `'left'` \| `'right'` \| `'center-horizontal'` \| `'center-vertical'` | A string that determines the alignment of the popover relative to the `refEl`. | `'bottom'` | | |||
| | `justify` | `'start'` \| `'middle'` \| `'end'` \| `'fit'` | A string that determines the justification of the popover relative to the `refEl`. Justification will be defined relative to the `align` prop | `'start'` | | |||
There was a problem hiding this comment.
Are we intentionally removing end here as well?
There was a problem hiding this comment.
oops no that's a mistake. added that back
4 tasks
stephl3
force-pushed
the
steph/po-deprecate-justify-fit
branch
2 times, most recently
from
15a4e16
to
a3b0c52
Compare
Base automatically changed from
steph/po-floating
to
LG-4121-popover-refactor
September 16, 2024 21:27
stephl3
force-pushed
the
steph/po-deprecate-justify-fit
branch
from
a3b0c52
to
15e4bd0
Compare
stephl3
added a commit
that referenced
this pull request
Sep 16, 2024
…2474) * Remove justify fit from @leafygreen-ui/popover * Remove justify fit usage in packages using Popover * Changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Justify.Fitfrom @leafygreen-ui/popover`Justify.Fitusage from packages using<Popover>Why remove this?
Justify.Fitwas initially introduced 4+ years ago in #295. It's currently used 3 times across MongoDB repos. This seems to be a sign that it isn't clear what it's intended to do within the defined API forjustify.Both
alignandjustifyare intended to control positioning, butJustify.Fitattempts to also control the sizing of the popover element in certain cases. Continuing to support this adds complexity when using Floating UI, so I think it's better to remove at this time. Existing users should be able to utilize other props combinations or custom styling to achieve an identical UI. This deprecation has been cleared with design.Floating UI has a size middleware that can be leveraged for this purpose if there are future requests for resizing functionality.
🎟 Jira ticket: LG-4516
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changes