Fix get_payments, get_bulk_payments, and transfer #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneurlax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deepest apologies, in testing this this morning there is a single $new_amount that I've left behind in
transferas of #54 ... I will in the future make a more comprehensive unit testing suite to stop myself committing these mistakes in the future.In addition, I have just added a fix for the issue discussed at/around https://mattermost.getmonero.org/monero/pl/3onjcmhoypnodkfgm8dk9i4nse where PHP was not properly casting payment IDs as string.
get_paymentsandget_bulk_paymentsnow work as expected.