Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: versions-api #809

Closed
jarmoniuk opened this issue Nov 5, 2022 · 4 comments · Fixed by #810
Closed

Maintenance: versions-api #809

jarmoniuk opened this issue Nov 5, 2022 · 4 comments · Fixed by #810
Milestone

Comments

@jarmoniuk
Copy link
Contributor

Extract api to a separate module

@slawekjaranowski
Copy link
Member

We should think what should be versions-api.

For me versions-api should have only interfaces for component which can be extended / implemented as extension for versions-maven-plugin, like VersionComparator.

I would like to have a project structure like:

  • versions-api - public api for external extending plugin
  • versions-maven-plugin - core plugin
  • versions-report-maven-plugin - dedicated plugin for Maven site reports
  • versions-common/internal - shared implementation used in plugin, report-plugin - should be used only by versions project

@jarmoniuk
Copy link
Contributor Author

plus versions-enforcer

But I'd like to follow a more gradual approach for the time being, otherwise this will become a far too big of a PR

@slawekjaranowski
Copy link
Member

plus versions-enforcer

But I'd like to follow a more gradual approach for the time being, otherwise this will become a far too big of a PR

Yes, yes ... small steps.

@jarmoniuk
Copy link
Contributor Author

jarmoniuk commented Nov 5, 2022

Currently there's no clear separation of the API and service implementation. I'd like to separate the API to a separate module in the next stage. And now...

jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Nov 5, 2022
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Nov 5, 2022
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Nov 5, 2022
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Nov 13, 2022
@slawekjaranowski slawekjaranowski added this to the 2.14.0 milestone Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants