Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass cache imports from solve ptions to solve request #5143

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

Ignas
Copy link
Contributor

@Ignas Ignas commented Jul 10, 2024

At the moment build --import-cache option is ignored when not using any frontend. This makes sure the option is passed along to the actual solve request.

@Ignas Ignas force-pushed the pass-cache-imports-to-solve branch from 28bb5dc to 955f289 Compare July 10, 2024 14:41
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it is intentional that this is not working automatically. The cache source from the initial request could be always included, unless there is some use case where frontend absolutely wants to ignore them.

Copy link
Member

@jedevc jedevc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I had also noticed this at some point 🎉 Thanks for putting a patch together!

@jedevc jedevc merged commit 8f4aa21 into moby:master Jul 16, 2024
75 checks passed
@crazy-max crazy-max added this to the v0.16.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants