Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tab not visible on mobx-react 6.1.1 #56

Closed
deanvanniekerk opened this issue Jun 27, 2019 · 26 comments
Closed

Performance tab not visible on mobx-react 6.1.1 #56

deanvanniekerk opened this issue Jun 27, 2019 · 26 comments

Comments

@deanvanniekerk
Copy link

I think there might be an issue with the latest version of mobx and mobx-react.
If i have the below installed I dont see the performance and components tabs

"mobx": "5.10.1",
"mobx-react": "6.1.1",

Screen Shot 2019-06-27 at 09 19 36

but if i downgrade to

"mobx": "3.6.2",
"mobx-react": "4.4.3",

then all works fine.

Screen Shot 2019-06-27 at 09 13 25

Thank for the great plugin by the way 👍

@deanvanniekerk
Copy link
Author

To be more specific with the versions. I lose the tabs when going from mobx-react 5.4.4 -> 6.0.0

If it helps im using typescript, this is my config

{
    "compilerOptions": {
        "strictNullChecks": true,
        "esModuleInterop": true,
        "moduleResolution": "node",
        "noEmit": true,
        "target": "esnext",
        "allowJs": true,
        "jsx": "react",
        "baseUrl": "./",
        "paths": {
            "@/*": ["src/*"]
        },
        "typeRoots": ["node_modules/@types", "typings"],
        "experimentalDecorators": true,
        "emitDecoratorMetadata": true
    },
    "include": ["./src/"]
}

@Tsury
Copy link

Tsury commented Jun 28, 2019

I just see the Changes tab, using

"mobx": "5.10.1",
"mobx-react": "6.1.1",
"mobx-react-devtools": "6.1.1",

Using standalone version.

How can I also see the Components tab?

nanaya added a commit to nanaya/osu-web that referenced this issue Jul 1, 2019
Not 6.x because it breaks devtools [1].

[1] mobxjs/mobx-devtools#56
@blinkcat
Copy link

only changes tab, using

"mobx": "^4.12.0",
"mobx-react": "^6.1.1",
"react": "^16.8.6",
"react-dom": "^16.8.6",

@FrederickIge
Copy link

same issue here

@ghost
Copy link

ghost commented Aug 3, 2019

me too.

@ibovegar
Copy link

Using firefox plugin. Same issue as well.

@bichotll
Copy link

Same here.

@alexalv
Copy link

alexalv commented Aug 26, 2019

Same here, using

"mobx": "^5.13.0",
"mobx-react": "^6.1.3",

@damienallen
Copy link

Same problem with FF, Chrome and the standalone version.

{
    "mobx": "^5.13.0",
    "mobx-react": "^6.1.3",
}

@nulldef
Copy link

nulldef commented Sep 4, 2019

Same problem here

@williamoliveira
Copy link

Is anyone working on a fix for this or is this project dead?

@anikethsaha
Copy link

I am trying to fix it. Hope to submit the ASAP.

@williamoliveira
Copy link

@anikethsaha is it a complex fix? has much changed?

@anikethsaha
Copy link

I guess no, updating a few methods. But getting other errors so just fixing those.
I have a fix ready for it but it will break other things. 😄

@danielkcz
Copy link

From mobx-react 6 changelog ... I can believe nobody here actually read it 😆

image

@anikethsaha
Copy link

Yea I actually forgot to comment about these . i had a look in the changelog and I already started without this. Sorry for not mentioning here.
I was trying to port the devtool support for v6 but couldn't do it as it was not easy as I thought.

@williamoliveira
Copy link

@FredyC do you have some info on why it was killed?

@danielkcz
Copy link

I think @mweststrate can answer that better, but mostly I believe it was because there are better tools today (like React Devtools) so there is no point having another specific tool.

@mweststrate
Copy link
Member

mweststrate commented Oct 14, 2019 via email

@williamoliveira
Copy link

Ok, that covers re-rendering visualization, but what about visualizing what components reacts to and what actions are updating?

@danielkcz
Copy link

danielkcz commented Oct 14, 2019

@williamoliveira See the last point in the picture I posted above or original changelog with links. I don't have personal experience with it, though. Strangely enough, I never had a need to investigate why is something re-rendering, it kinda made sense to me without any tool.

@Venryx
Copy link
Contributor

Venryx commented Nov 12, 2019

Just wanted to mention that this is one of the first things I'll be looking to add to my fork here: https://github.com/Venryx/mobx-devtools-advanced

We'll see if I succeed in implementing it, but it's certainly something I'll try to add, as deep dependency tree viewing is something I really miss from my custom dependency tracking system I'd used prior to transitioning to MobX.

@Venryx
Copy link
Contributor

Venryx commented Nov 17, 2019

Just got a very primitive implementation working for viewing the list of observables that an @observer component is watching:

I want to emphasize that the screenshot above is not at all representative of the final state, it's just a first demonstration that the pathway for displaying the information is in place. The full implementation will have expanding of component subtrees like before, arbitrarily-deep expansion of the dependency tree for each component, no need to manually press the "Refresh" button for things, much nicer layout and styling, etc.

That said, the basic functionality does work, so if someone urgently needs the functionality, they can clone my forked repo and install it locally: https://github.com/Venryx/mobx-devtools-advanced

Local install instructions (possibly incomplete): https://github.com/Venryx/mobx-devtools-advanced/blob/master/Docs/Hacking.md

@Venryx
Copy link
Contributor

Venryx commented Nov 17, 2019

Updates:

  • The extension now lets you view the "deep dependencies" of a component.
  • The data-viewer UI uses an expandable tree. (rather than flat json display)

I'll definitely work on this more, though progress may be sparse atm, since currently I'm only implementing the features I need to efficiently debug some issues in my main project.

Once I resolve those issues in my main project, I can revisit the extension to give it some much needed feature development and UI improvement.

@Venryx
Copy link
Contributor

Venryx commented Dec 15, 2019

I've been making some more progress on my fork, but from now on I'll give updates on its development in this other issue: #55

@epodgaetskiy
Copy link
Collaborator

Hi!
Prefer use React Devtools extension for components tree and performance discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests