Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop API version 2.2 from VALID_API_VERSIONS #347

Closed
wants to merge 1 commit into from
Closed

Drop API version 2.2 from VALID_API_VERSIONS #347

wants to merge 1 commit into from

Conversation

solarissmoke
Copy link
Contributor

@solarissmoke solarissmoke commented Mar 4, 2017 •
edited
Loading

Facebook is terminating support for API version 2.2 on 25 March 2017 (see https://developers.facebook.com/docs/apps/changelog).

martey
martey requested changes Mar 9, 2017
View reviewed changes
Copy link
Member

@martey martey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the point that v2.2 is still available for another 2 weeks, this pull request doesn't update the documentation.

@solarissmoke
Drop API version 2.2 from VALID_API_VERSIONS
a8d368f 
Facebook is terminating support for API version 2.2 on 25 March 2017.
@solarissmoke
Copy link
Contributor Author

This pull request doesn't update the documentation.

Updated with changes to documentation.

v2.2 is still available for another 2 weeks

Up to you when you cut a new release. That said, I don't see what the problem is with allowing (in fact encouraging) users to upgrade ahead of the deadline.

@martey
Copy link
Member

martey commented Mar 10, 2017

That said, I don't see what the problem is with allowing (in fact encouraging) users to upgrade ahead of the deadline.

If an API version isn't listed in VALID_API_VERSIONS, an error message is raised. Removing API versions ahead of a deadline isn't "allowing" users to upgrade, it is forcing them.

martey
martey approved these changes Mar 10, 2017
View reviewed changes
Copy link
Member

@martey martey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed earlier, I won't be merging this until after the deadline, but it looks good to me (I especially love that you squashed your commits).

martey added a commit that referenced this pull request Mar 25, 2017
@martey
Merge #347 (drop support for API version 2.2).
ea4e43c
@martey martey closed this Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martey martey martey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solarissmoke @martey