Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add as_task_clust() converter #12

Merged
merged 8 commits into from
May 31, 2021
Merged

Add as_task_clust() converter #12

merged 8 commits into from
May 31, 2021

Conversation

mllg
Copy link
Sponsor Member

@mllg mllg commented Feb 3, 2021

We want to avoid new users to instantly be confronted with R6 during task construction. Instead, they can call as_task_clust(<data.frame>).

Also, as_prediction_clust() allows converting back data tables generated by as.data.table.PredictionClust().

@mllg mllg requested a review from damirpolat May 26, 2021 07:28
@pfistfl
Copy link
Sponsor Member

pfistfl commented May 28, 2021

We could, in this context also try to get mlr3's convert_task working with cluster tasks.
This is currently impossible since convert_task tries to set a target, which is not allowed in for cluster tasks..

@damirpolat
Copy link
Member

This looks good, thank you!

@damirpolat
Copy link
Member

We could, in this context also try to get mlr3's convert_task working with cluster tasks.
This is currently impossible since convert_task tries to set a target, which is not allowed in for cluster tasks..

Not sure if that would be necessary? Also, that would mean that mlr3 relies on mlr3cluster. Would that be acceptable?

@damirpolat damirpolat merged commit 0622444 into main May 31, 2021
@mllg mllg deleted the as_task_clust branch October 4, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants