undefine conflicting As macro #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcurtin
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Yeah, agreed. I think one of the build jobs will fail unless you add something to HISTORY.md, but actually looking at the build jobs... I think the CI is not in a great state at the moment. Happy to merge anyway, I'm sure this won't break anything internally.
conradsnicta
added
t: bug in other software
and removed
s: needs review
s: unanswered
labels
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR; Undefine conflicting 'As' macro which interferes with ensmallen. This stems from mlpack/mlpack#3501
Long story:
Class Library for Numbers (CLN; https://www.ginac.de/CLN/) is used by several other projects for scientific computing. With infinite wisdom, CLN defines a conflicting "As" macro. This prevents ensmallen (and hence mlpack) from being used in conjunction with CLN or any other project that uses CLN.
The proper fix would be to correct the CLN source. However, CLN has been around for a long while, and various old versions are vendored inside many projects and distributed in many linux distros. Undefining the silly "As" macro handles old versions of CLN.
Offending code is on lines 269 and 274 in https://www.ginac.de/CLN/cln.git/?p=cln.git;a=blob;f=include/cln/number.h;h=67f68899a6926eca49722f012d0a20d159162c57;hb=HEAD#l269