Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial for mlc-llm model compilation in python #13

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

CharlieFRuan
Copy link
Contributor

No description provided.

Co-authored-by: CharlieRuan0130 <[email protected]>
Co-authored-by: sbelcmu <[email protected]>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

"name": "stdout",
"text": [
"Using path \"Llama-2-7b-chat-hf\" for model \"Llama-2-7b-chat-hf\"\n",
"WARNING: --db-path does not point to a valid database: []\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that the default value of --db-path is still "log_db" in BuildArgs https://github.com/mlc-ai/mlc-llm/blob/d4c3a17379e1e890db6650568d7b5a59650a17bd/mlc_llm/core.py#L60. So just a bit curious why it emits this warning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh I think this is because we are doing the model building in my_workspace instead of inside the mlc_llm repo. The intent is to show that, by installing the mlc_llm as a package, they can build wherever they want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Sounds good for now, as we will remove the database soon when dlight gets maturer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for the suggestions!

Copy link
Member

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very pretty! Thanks @CharlieRuan0130 and @sbelcmu for the notebook. Left two comments above and we are good to go after addressing them.

Co-authored-by: Ruihang Lai <[email protected]>
@MasterJH5574 MasterJH5574 merged commit a643da1 into mlc-ai:main Jul 24, 2023
@CharlieFRuan CharlieFRuan deleted the tutorial-compile-model branch August 16, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants