Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for large chunks of data #3

Merged
merged 1 commit into from
Jul 24, 2013
Merged

Conversation

henghonglee
Copy link
Contributor

Server was not performing well for large chunks of data, added support for counting bytes on the server to wait for more data from the stream when not full.

mirek added a commit that referenced this pull request Jul 24, 2013
Added support for large chunks of data
@mirek mirek merged commit aa68efd into mirek:master Jul 24, 2013
@mirek
Copy link
Owner

mirek commented Sep 15, 2013

Dude, your PR was completely broken, segfaulting on reading frame, reverted it for now if you want you can create fixed PR, looks like you've forgotten to add init code for currentData.

@henghonglee
Copy link
Contributor Author

Oh I'm so sorry bout that I think I missed out part of the code that I
added (was working on it in another project). I'll submit a fixed soon

On Monday, September 16, 2013, Mirek Rusin wrote:

Dude, your PR was completely broken, segfaulting on reading frame,
reverted it for now if you want you can create fixed PR, looks like you've
forgotten to add init code for currentData.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-24482206
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants