Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beautify the UI a tiny little bit #2

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Beautify the UI a tiny little bit #2

merged 6 commits into from
Jan 30, 2024

Conversation

Bombe
Copy link
Collaborator

@Bombe Bombe commented Jan 29, 2024

This pull requests adds three small changes:

  • It visually unifies the padding on the left and the right side of the folder select box and the character/account select boxes.
  • It adds tooltips for the “select folder” and “open folder” buttons.
  • It makes the character/account select lists smaller on macOS, partially reverting 35234e6. On my system the increased size caused the lists and the buttons below them to overlap.

@Bombe
💄 Make margins appear more uniform
23bf84e
@Bombe
💄 Add tooltips to “select folder” and “open folder” buttons
1a5ca60
@Bombe
💄 Make select list on macOS a bit smaller
081ead7 
It caused the lower end of the select lists to overlap with the buttons
below.

I realize that this apparently was added specifically for macOS but I
can’t find any justification for it, and it breaks the layout, so
reverting that particular change seems like the prudent way to fix this.
@mintnick
Copy link
Owner

Thank you so much for the great work!
I will just run some test and add new tooltips in other languages.

@mintnick mintnick merged commit 9623643 into mintnick:main Jan 30, 2024
@Bombe Bombe deleted the feature/beautify-ui branch January 30, 2024 12:23
@Bombe
Copy link
Collaborator Author

Bombe commented Jan 30, 2024

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bombe @mintnick