Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker improvements #290

Merged
merged 11 commits into from
May 31, 2024
Merged

Tracker improvements #290

merged 11 commits into from
May 31, 2024

Conversation

YourAverageLink
Copy link
Contributor

@YourAverageLink YourAverageLink commented May 28, 2024

What does this PR do?

Adds some extra functionality to the tracker.

  • Right-clicking an area marker will check all of its locations
  • Users can sphere-track items by marking a location and then marking the item they found there. Once marked, the item will appear as a small icon beside the location it was found at. The tracker will display what sphere of logic a location is in, and mousing over an item on the tracker will show all locations that contained the item.
  • Users may now mark hints for a region. Once a hint is added, it will appear in that region's marker tooltip, as well as the tooltip of its parent province, if applicable.

How do you test this changes?

I have marked various items and locations to make sure that the sphere tracking looks reasonably correct, but more testing would always be appreciated.

Notes

At some point, we should probably make sphere tracking optional, perhaps with a popup Fi dialog that also explains the feature.

@YourAverageLink YourAverageLink added the suggestion ✨ New feature or request label May 29, 2024
Copy link
Contributor

@gymnast86 gymnast86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. If you could also make it so that hovering over the dungeon abbreviations shows the full dungeon name on the lower text which also shows the item names, I think that would be a good addition.

@YourAverageLink YourAverageLink dismissed gymnast86’s stale review May 31, 2024 16:20

Addressed by latest commit

@YourAverageLink YourAverageLink merged commit dbe4c94 into mint-choc-chip-skyblade:main May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants