fix version naming convention to have 'v' prefix #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is needed to follow `vgo` guidelines put forth by Go community. https://github.com/golang/vgo/blob/master/vendor/cmd/go/internal/semver/semver.go#L6 > // semantic version strings must begin with a leading "v" Supported format style https://github.com/golang/vgo/blob/master/vendor/cmd/go/internal/semver/semver.go#L11 > // vMAJOR[.MINOR[.PATCH[-PRERELEASE][+BUILD]]] Fixes minio#985
nitisht
approved these changes
May 29, 2018
krisis
approved these changes
May 29, 2018
|
Sorry for jumping in here, this change seems to be not related to what I suggested in #985: It was just about the tags in the git repository for minio-go, so from my point of view (and Go's) the string in the library does not matter at all. The version is still 6.0.1, just the version tag (in git) should be |
|
Now the tag is v6.0.2 we won't be changing the old tags is that needed as well ?. The string is needed because that is used to automatically release the library. |
|
ah, I didn't see that earlier, that's sufficient. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed to follow
vgoguidelinesput forth by Go community.
https://github.com/golang/vgo/blob/master/vendor/cmd/go/internal/semver/semver.go#L6
Supported format style
https://github.com/golang/vgo/blob/master/vendor/cmd/go/internal/semver/semver.go#L11
Fixes #985