endpoint: Validate endpoint properly using isDomainName and isValidIP #260
Conversation
harshavardhana
force-pushed
the
valid
branch
from
8960633
to
46e6f9d
Compare
| @@ -34,6 +35,63 @@ var maxParts = int64(10000) | |||
| // maxPartSize - maximum part size for a single multipart upload operation. | |||
| var maxPartSize int64 = 1024 * 1024 * 1024 * 5 | |||
|
|
|||
| // isDomainName validates input string if it conforms with | |||
| // RFC 1035 and RFC 3696 for domain standards. | |||
| func isDomainName(host string) bool { | |||
harshavardhana
force-pushed
the
valid
branch
4 times, most recently
from
e06f253
to
39f333f
Compare
| // if string larger than 255 characters return false. | ||
| return false | ||
| } | ||
| if host[(len(host)-1):] == "-" || host[:1] == "-" { |
There was a problem hiding this comment.
Based on RFC, this gets very complicated. Also they keep expanding the rules. We are better of doing some minimal regex rules to eliminate invalid domain names for known cases and let others pass through. This can be a series of regex checks to keep it readable.
harshavardhana
force-pushed
the
valid
branch
3 times, most recently
from
7ce039c
to
0367ca6
Compare
| return false | ||
| } | ||
| // host cannot start with a "." | ||
| if host[:1] == "." { |
There was a problem hiding this comment.
Cannot end with "." as well.
Domains can end with "." - those are called absolute domains. |
harshavardhana
force-pushed
the
valid
branch
from
0367ca6
to
666e8e2
Compare
http://www.dns-sd.org/trailingdotsindomainnames.html - for example a request to "https://www.example.com." is as valid as "https://www.example.com" |
You are right since this will be for our purposes, i do not see we need to be Browser like generic in validating domain names. |
harshavardhana
force-pushed
the
valid
branch
from
666e8e2
to
7415c56
Compare
harshavardhana
force-pushed
the
valid
branch
from
7415c56
to
09482ac
Compare
endpoint: Validate endpoint properly using isDomainName and isValidIP
No description provided.