-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get bucket versioning #1266
Conversation
Implement GetBucketVersioning returning a GetBucketVersioningConfiguration structure. Add example for GetBucketVersioning Add doc for GetBucketVersioning
what is the purpose of just adding GetBucketVersioning? @clook |
d9505b8
to
b838ab0
Compare
Hi @harshavardhana, the goal is to be able to get the versioning status of bucket (https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketVersioning.html). Currently, I'm using https://github.com/aminueza/terraform-provider-minio which relies on minio-go but am unable to provision a bucket with versioning configuration. I could easily make a PR for https://github.com/aminueza/terraform-provider-minio if |
@clook thanks for the explanation - it makes sense, but what is the pre-requisite of using bucket versioning with Terraform? |
@harshavardhana The pre-requesite for the Terrraform provider is to be able to compare the Terraform current known state with the real resource state and then guess if it has to apply |
Also tell me if you want some unit tests to be performed. Right now, I mostly templated over |
Implement GetBucketVersioning