Fix listObjects hang when listing special characters #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reproduceThis will hang forever listing first 1000 entries repeatedly. |
harshavardhana
force-pushed
the
fix-list
branch
from
9948cdf
to
0ffee18
Compare
7 tasks
vadmeste
previously requested changes
Sep 23, 2019
There was a problem hiding this comment.
@harshavardhana NextContinuationToken needs also to be unescaped in ListObjectsV2
|
@vadmeste looks like that is only for MinIO since it's an opaque value in AWS S3 |
This PR 1e01719 introduced a regression in handling special character file listing, this causes `mc ls` like commands to hang. Fixes minio/mc#2903
harshavardhana
force-pushed
the
fix-list
branch
from
0ffee18
to
78172f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR 1e01719 introduced
a regression in handling special character file listing, this
causes
mc lslike commands to hang.Fixes minio/mc#2903