Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new method GetObjectACL() #1011

Merged
merged 8 commits into from
Jul 27, 2018
Merged

Conversation

pierre-emmanuelJ
Copy link
Contributor

@pierre-emmanuelJ pierre-emmanuelJ commented Jul 20, 2018

Example:

objInfo, err := minioClient.GetObjectACL("bucketName", "objectName")
if err != nil {
	return err
}

//object ACLs is in the Metadata header with stat details
fmt.Printf("%#v\n", "objInfo.Metadata")

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add copyright info here.

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
@@ -0,0 +1,138 @@
/*
* Minio Go Library for Amazon S3 Compatible Cloud Storage
* Copyright 2017 Minio, Inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The year has to be 2018

Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pierre-emmanuelJ . Do you mind adding a test here https://github.com/minio/minio-go/blob/master/functional_tests.go

You can add check like this https://github.com/minio/minio-go/blob/master/functional_tests.go#L293 so it runs only for S3 endpoints

@pierre-emmanuelJ pierre-emmanuelJ force-pushed the object-acl branch 4 times, most recently from f7498a1 to e2f66b2 Compare July 23, 2018 11:11
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
@pierre-emmanuelJ
Copy link
Contributor Author

@nitisht Do you want an example here ?

@nitisht
Copy link
Contributor

nitisht commented Jul 26, 2018

@nitisht Do you want an example here ?

Yes, please. That'd be great

@pierre-emmanuelJ pierre-emmanuelJ force-pushed the object-acl branch 2 times, most recently from 1c130e3 to d3ef7af Compare July 26, 2018 14:20
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 9590375 into minio:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants