-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new method GetObjectACL() #1011
Conversation
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add copyright info here.
cd41e59
to
70f0ccc
Compare
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
70f0ccc
to
f49893b
Compare
api-get-object-acl.go
Outdated
@@ -0,0 +1,138 @@ | |||
/* | |||
* Minio Go Library for Amazon S3 Compatible Cloud Storage | |||
* Copyright 2017 Minio, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The year has to be 2018
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @pierre-emmanuelJ . Do you mind adding a test here https://github.com/minio/minio-go/blob/master/functional_tests.go
You can add check like this https://github.com/minio/minio-go/blob/master/functional_tests.go#L293 so it runs only for S3 endpoints
f7498a1
to
e2f66b2
Compare
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
567ac1d
to
f2897a9
Compare
Yes, please. That'd be great |
1c130e3
to
d3ef7af
Compare
Signed-off-by: Pierre-Emmanuel Jacquier <[email protected]>
d3ef7af
to
6d14470
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Example: