Fix TLSA parsing #211
Merged
Fix TLSA parsing #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If found return them. Not that we only return them in looping constructs, i.e. endingTo*, in the other ones it will silently fail still.
|
I will try this for real zones and report how it goes. |
|
This fix works for all TLSA records I got. Thank you. |
|
[ Quoting [email protected] in "Re: [dns] Fix TLSA parsing (#211)..." ]
Cool. Merging /Miek Miek Gieben |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an overflow and report back a proper error when we hit that limit.