SelectBox Custom: Hide Drop-down on Dispose. Fixes: #40962 #40974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleidigh
changed the title
|
Fixes: #40962 |
|
I think this way is fine, good catch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bpasero
@Tyriar
@isidorn
Happy New Years ! 🎆 🎊
Been great working with you guys this year, look forward to the next 👍
When the panel is closed while the Drop-down is open it does not receive a blur event which is how the Drop-down is usually closed. I tried using a MutationObserver without luck, had to do the hide within the dispose.
public dispose(): void {
this.hideSelectDropDown(false);
this.toDispose = dispose(this.toDispose);
}
Seems indirect, anything more appropriate?
Cheers