Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line confidence to shellIntegration API #209946

Merged
merged 7 commits into from
Apr 9, 2024

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Apr 9, 2024

Part #145234

@Tyriar Tyriar added this to the April 2024 milestone Apr 9, 2024
@Tyriar Tyriar self-assigned this Apr 9, 2024
@Tyriar Tyriar requested a review from meganrogge April 9, 2024 14:52
@Tyriar Tyriar marked this pull request as ready for review April 9, 2024 14:52
@@ -112,8 +112,8 @@ __vsc_update_cwd() {
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why were these moved to below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get the command line before command execute fires, this should greatly improve the results and likely other features from shell integration too

meganrogge
meganrogge previously approved these changes Apr 9, 2024
@Tyriar Tyriar merged commit 7c1fa38 into main Apr 9, 2024
6 checks passed
@Tyriar Tyriar deleted the tyriar/145234_confidence branch April 9, 2024 15:25
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants