Support Ctrl+A in notebook outputs #207548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
force-pushed
the
issue206017
branch
from
9ef95e4
to
fcfde08
Compare
DonJayamanne
commented
Mar 13, 2024
amunger
reviewed
Mar 13, 2024
src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts
Outdated
Show resolved
Hide resolved
DonJayamanne
force-pushed
the
issue206017
branch
from
1417323
to
7b7ca54
Compare
amunger
reviewed
Mar 14, 2024
src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts
Outdated
Show resolved
Hide resolved
DonJayamanne
commented
Mar 14, 2024
|
@joaomoreno @mattbierner Please can you check whether these changes in ListView and WebView areas are right. |
joaomoreno
reviewed
Mar 15, 2024
DonJayamanne
requested review from
rebornix and
amunger
and removed request for
mjbvz
rebornix
approved these changes
Mar 17, 2024
chen-ky
pushed a commit
to chen-ky/vscode
that referenced
this pull request
Mar 18, 2024
* Support Ctrl+A in notebook outputs * Better handling of outputs * oops * Better determination of outputId
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206017
Fixes #204023