Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

userSelectedModel is not available on every ChatRequest object #229616

Closed
lramos15 opened this issue Sep 24, 2024 · 1 comment · Fixed by #229764 or #230028
Closed

userSelectedModel is not available on every ChatRequest object #229616

lramos15 opened this issue Sep 24, 2024 · 1 comment · Fixed by #229764 or #230028
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release panel-chat verification-found Issue verification failed
Milestone
September 2024

Comments

@lramos15
Copy link
Member

lramos15 commented Sep 24, 2024 •
edited
Loading

It appears that provideParticipantDetection does not have userSelectedModel. It's likely that every ChatRequest should have this property.

Are we creating a separate instance for provideParticipantDetection? I would expect it to be one instance for all calls that are associated with a given request.
@roblourens roblourens added this to the September 2024 milestone Sep 25, 2024
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug panel-chat labels Sep 25, 2024
roblourens added a commit that referenced this issue Sep 25, 2024
@roblourens
Include userSelectedModelId in participant detection request
5fcd680 
Fix #229616
@roblourens roblourens mentioned this issue Sep 25, 2024
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Sep 25, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 26, 2024
@lramos15 lramos15 added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Sep 27, 2024
@lramos15
Copy link
Member Author

@roblourens still not seeing this

Image

@lramos15 lramos15 reopened this Sep 27, 2024
@vs-code-engineering vs-code-engineering bot removed the insiders-released Patch has been released in VS Code Insiders label Sep 27, 2024
@roblourens roblourens added the candidate Issue identified as probable candidate for fixing in the next release label Sep 27, 2024
roblourens added a commit that referenced this issue Sep 27, 2024
@roblourens
Correctly pass user selected LM for intent detection
e7f039a 
Fix #229616
@roblourens roblourens mentioned this issue Sep 27, 2024
Merged
roblourens added a commit that referenced this issue Sep 27, 2024
@roblourens
Correctly pass user selected LM for intent detection (#230014)
106df9b 
Fix #229616
roblourens added a commit that referenced this issue Sep 27, 2024
@roblourens
Correctly pass user selected LM for intent detection (#230014)
fdaa66f 
Fix #229616
@roblourens roblourens mentioned this issue Sep 27, 2024
Merged
roblourens added a commit that referenced this issue Sep 27, 2024
@roblourens
Correctly pass user selected LM for intent detection (#230014) (#230028)
ef69ffe 
Fix #229616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release panel-chat verification-found Issue verification failed
Projects
None yet
Milestone
September 2024
2 participants
@roblourens @lramos15