Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session status #91

Merged
merged 7 commits into from
Feb 23, 2023
Merged

Session status #91

merged 7 commits into from
Feb 23, 2023

Conversation

forwardpointer
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

  • Implements OnSessionStatusChanged

Developer Focus

  • Added a m_sessionStatus private member that keeps track of the previous session status. Does it make sense to have the m_sessionStatus.SessionId possibly out of sync with the UwbSession::m_sessionId, especially upon initialization?

@forwardpointer forwardpointer requested a review from a team as a code owner February 22, 2023 22:17
abeltrano
abeltrano requested changes Feb 22, 2023
View reviewed changes
lib/uwb/UwbDevice.cxx Outdated Show resolved Hide resolved
lib/uwb/include/uwb/UwbSession.hxx Outdated Show resolved Hide resolved
lib/uwb/include/uwb/UwbSession.hxx Outdated Show resolved Hide resolved
abeltrano
abeltrano reviewed Feb 22, 2023
View reviewed changes
lib/uwb/UwbSession.cxx Outdated Show resolved Hide resolved
@forwardpointer forwardpointer merged commit 65dd9fb into develop Feb 23, 2023
@abeltrano abeltrano deleted the sessionStatus branch March 14, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeltrano abeltrano abeltrano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forwardpointer @abeltrano