Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neutral <-> ddi conversion functions involving types with flex-array members #89

Merged
merged 8 commits into from
Feb 22, 2023

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Ensure the neutral <-> ddi conversion functions involving DDI types with flexible array member (FAM) types can be converted correctly.

Technical Details

  • Update conversion functions with FAMs to use flextype_wrapper.
  • Add constraint for flextype_wrapper::element_type to not be an array type.

Test Results

All unit tests pass on both Linux and Windows.

Reviewer Focus

None

Future Work

  • Unit tests for each conversion function need to be added.
  • Some of the conversion functions that are not needed now were left unimplemented. These will need to be completed at some point.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner February 22, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant