-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plog debug wrapper #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement wrapper for plog to output stuff to the debugger
abeltrano
reviewed
Feb 14, 2023
windows/shared/logging/logging-plog-windows/include/logging/windows/PlogDebugWrapper.hxx
Outdated
Show resolved
Hide resolved
windows/shared/logging/logging-plog-windows/include/logging/windows/PlogDebugWrapper.hxx
Outdated
Show resolved
Hide resolved
windows/shared/logging/logging-plog-windows/include/logging/windows/PlogDebugWrapper.hxx
Outdated
Show resolved
Hide resolved
abeltrano
reviewed
Feb 14, 2023
abeltrano
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same code as PR #72. I just forgot to update the destination branch to develop instead of plog_etw, so this will need to be merged again.