Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable FETCH_CONTENT of plog #51

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Enable FETCH_CONTENT of plog #51

merged 4 commits into from
Jan 27, 2023

Conversation

forwardpointer
Copy link
Contributor

@forwardpointer forwardpointer commented Jan 27, 2023 •
edited
Loading

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Enables use of the open source plog library

Test Results

I verified that I was able to include the headers in nocli and use the plog macros there.

Future Work

Actually use plog to log stuff.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@forwardpointer forwardpointer requested a review from a team as a code owner January 27, 2023 18:41
@forwardpointer forwardpointer merged commit f9af948 into develop Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeltrano abeltrano abeltrano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forwardpointer @abeltrano