Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set plog version #50

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Explicitly set plog version #50

merged 1 commit into from
Jan 27, 2023

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Jan 27, 2023 •
edited
Loading

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Ensure plog is sourced at a specific version to ensure build stability.

Technical Details

Test Results

Built the project with the vcpkg-dev preset and manually inspected the vcpkg build tree to ensure that version 1.1.9 was present.

Reviewer Focus

None

Future Work

None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 27, 2023 04:34
@abeltrano abeltrano mentioned this pull request Jan 27, 2023
Merged
10 tasks
@abeltrano abeltrano changed the title Explicitly set plog version to use Explicitly set plog version Jan 27, 2023
@abeltrano abeltrano merged commit d8890d6 into develop Jan 27, 2023
@abeltrano abeltrano deleted the fixplogversion branch January 27, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano