Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::format for all logging in UwbConnector #310

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Simplify logging in UwbConnector.

Technical Details

  • Switch all manually formatted lines using i/o manipulators to using std::format.

Test Results

Ran ad-hoc tests and verified output looked as expected.

Reviewer Focus

Consider whether there are any cases where the number of format tokens doesn't match the number of matching arguments.

Future Work

  • Other complicated logging code in Windows using manipulators could be simplified using std::format.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner June 20, 2023 13:10
@abeltrano abeltrano merged commit 455f9b2 into develop Jun 20, 2023
@abeltrano abeltrano deleted the fmtlogging branch June 20, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant