Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Q97 to double conversion #296

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

corbin-phipps
Copy link
Contributor

@corbin-phipps corbin-phipps commented Jun 9, 2023

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

This PR fixes the conversion from ARM Q9.7 format to IEEE 754 double precision format. Fixes #294

Technical Details

  • Added twos complement conversion of "integer" part if the "sign" bit is set.
  • Minor syntax improvements.

Test Results

Verified expected conversion results using TestClient driver.

Reviewer Focus

None.

Future Work

Unit tests still need to be added.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@corbin-phipps corbin-phipps requested a review from a team as a code owner June 9, 2023 00:41
@abeltrano abeltrano merged commit 296618d into develop Jun 9, 2023
@abeltrano abeltrano deleted the user/corbinphipps/fix-ranging-measurement branch June 9, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConvertQ97FormatToIEEE() incorrectly converts ARM Q9.7
2 participants