Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows UwbCx driver DDI #29

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Update Windows UwbCx driver DDI #29

merged 3 commits into from
Jan 12, 2023

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Jan 12, 2023

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

  • Enable up-to-date development with Windows UwbCx driver DDI.
  • Eliminate unneeded link libraries.

Technical Details

  • Sync UwbCx interface with engineering drop commit @ 18dd10c645a1e on 12/27/2022.
  • This was a straight copy, with updates to account for field types.
  • Remove cfgmgr32.lib link dependencies from libs that don't need it or acquire it indirectly.
  • Remove re-defined ioctl structures and macros, replacing them with appropriate user-mode header.

Test Results

Compile-tested on Windows.

Reviewer Focus

None

Future Work

The uwbcx lib should probably move to be under windows/devices/uwb for consistency, however, there are outstanding PRs involving code in that tree, so this will be done late.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner January 12, 2023 23:14
@abeltrano abeltrano merged commit 2b929dc into develop Jan 12, 2023
@abeltrano abeltrano deleted the fixcxdeps branch January 12, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant