Always send at least sizeof(UWB_NOTIFICATION_DATA) bytes for notifications #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Goals
Currently, the handling of notifications is failing the UWB CX validation test. This happens because the CX requires a buffer of at least
sizeof(UWB_NOTIFICATION_DATA)
(0x50) bytes, butlpBytesReturned
ofDeviceIoControl
returns fewer bytes. The reason for this is becauseUWB_NOTIFICATION_DATA
has a union member, which causessizeof
to account for the largest member in the union. A specific notification of the non-largest type may actually use fewer bytes than whatsizeof
calculates for the union.Therefore, the notification handling should always send at least
sizeof(UWB_NOTIFICATION_DATA)
bytes, not just the number of bytes actually used for a specific notification.Technical Details
bytesRequired
andsizeof(UWB_NOTIFICATION_DATA)
.Test Results
nocli output displays expected values, eliminating the unexpected "insufficient buffer" messages from before.
Reviewer Focus
None.
Future Work
None.
Checklist
all
compiles cleanly.