Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NavigationView to OobSimulator #265

Merged
merged 3 commits into from
May 9, 2023
Merged

Add NavigationView to OobSimulator #265

merged 3 commits into from
May 9, 2023

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Allow navigation of multiple pages and/or features.

Technical Details

  • Add a primary Page control called MainPage to be the content of the primary window, MainWindow.
  • Add a NavigationView control to organize pages within the application.
  • Add UWB section to navigation view with UWB Session Data Generator item (default).

Test Results

  • Launched the app, changed some UI values, clicked Set UWB Session Data and verified it produced the expected output file.

Reviewer Focus

None

Screenshots

image

Future Work

  • A dedicated settings page needs to be added.
  • The UwbSessionDataPage UI elements could be laid out a bit more neatly.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner May 8, 2023 23:11
@abeltrano abeltrano merged commit ee51708 into develop May 9, 2023
@abeltrano abeltrano deleted the oobsimnavview branch May 9, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants