Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with /bigobj on Windows #241

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Compile with /bigobj on Windows #241

merged 1 commit into from
Apr 19, 2023

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Allow building framework on ARM64 Compiled Hybrid Portable Executable (CHPE) platforms.

Technical Details

  • Compile with /bigobj with MSVC on Windows to allow static libraries to have more than the default number of sections, which seems to occur on ARM64 CHPE.

Test Results

Compile-tested only.

Reviewer Focus

None

Future Work

None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner April 19, 2023 22:03
@abeltrano abeltrano merged commit 6d618b0 into develop Apr 19, 2023
@abeltrano abeltrano deleted the bigobj branch April 19, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant