Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple UwbConnector event registrations #217

Merged
merged 4 commits into from
Apr 7, 2023
Merged

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Apr 7, 2023

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Allow multiple event consumers to register with UwbConnector.

Technical Details

  • Convert the members storing callbacks to store containers (std::vector) instead of individual elements.
  • Add helper functions to produce a copy of event callbacks, erasing any that are found to be expired in the process.

Test Results

  • Ran end-to-end ranging test, enabled+disabled random measurements on session, observed all events in nocli output.

Reviewer Focus

None

Future Work

This paves the way to allow a single UbwConnector to be used for both UwbDevice and its child UwbSession objects.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner April 7, 2023 13:58
@abeltrano abeltrano merged commit 9616985 into develop Apr 7, 2023
@abeltrano abeltrano deleted the eventsource branch April 7, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant