Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autostart no cv #203

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Autostart no cv #203

merged 4 commits into from
Apr 4, 2023

Conversation

forwardpointer
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Describe what the PR intends to achieve. If the change is a new feature, describe what it is. If the change is a bug fix, reference the issue being fixed. Provide any additional context and motivation for making the change. Eg.

Simplify maintenance of the event loop. A well-known open source library can be used in place of the custom written code, making it easier to use, understand, and debug.

Technical Details

Describe how the goals of the PR were achieved. Eg.

Replace custom event loop code with libevent.

Test Results

Describe which tests were carried out and a summary of their results. Eg.

Verified Near Object session completed successfully with the following configurations:

  • host as controlee
  • host as controller

Reviewer Focus

Describe what reviewers should focus on. Eg.

The event loop could cause the service to exit early if it does not manage object lifetime correctly. Please pay careful attention to how this is achieved in the new event loop.

Future Work

Describe any future work that is required as a result of this change. Eg.

  • Long-running stress testing needs to be completed.
  • The old event loop code needs to be removed once stress-testing with libevent has been completed.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@forwardpointer forwardpointer requested a review from a team as a code owner April 4, 2023 17:44
@forwardpointer forwardpointer changed the base branch from develop to autostart April 4, 2023 17:45
@forwardpointer forwardpointer reopened this Apr 4, 2023
@forwardpointer forwardpointer merged commit 498a1b0 into autostart Apr 4, 2023
@abeltrano abeltrano deleted the autostart_no_cv branch May 2, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants