Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store session event state with device instead of open file handle #177

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Ensure random measurement generation can be instrumented externally and across open file handles.

Technical Details

  • Move i/o event queue state from file context to device context.
  • Fix ioctl attempt count log output (was off-by-1).

Test Results

Concurrently executed nocli.exe uwb range start <args> with uwbsim.exe trigger startrandomgeneration followed by "" .. stoprandomgeneration and successfully observed random measurements printed to the console.

Reviewer Focus

None

Future Work

  • Use proper smart pointers instead of raw pointers for device context structures and lifetime management.
  • Expose more knobs to configure how the random measurements are generated.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 28, 2023 21:23
@abeltrano abeltrano merged commit b48f6e4 into develop Mar 28, 2023
@abeltrano abeltrano deleted the simtrigger branch March 28, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant