Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cpp-lint workflow configuration for ignored libs and embedded clang-tidy file #17

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

  • Disable lint checks on notstd libs since we use a different coding style for those.
  • Enforce repo .clang-tidy file checks with cpp-lint workflow.

Technical Details

  • Add cpp-lint workflow ignore option with notstd directories.
  • Add cpp-lint workflow clang-tidy option with empty value, enabling use of repo-embedded .clang-tidy file.

Test Results

None, this will be tested on the next PR.

Reviewer Focus

None

Future Work

The .clang-tidy file needs to be modified such that external dependencies such as CLI11 and Catch2 are ignored. Since these files are compiled and get included in the compile_commands.json file, it's unclear how to do this.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner December 20, 2022 16:17
@abeltrano abeltrano changed the title Lintcfg Update cpp-lint workflow configuration for ignored libs and embedded clang-tidy file Dec 20, 2022
@abeltrano abeltrano merged commit b06b231 into develop Dec 20, 2022
@abeltrano abeltrano deleted the lintcfg branch December 20, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants