Separate driver and service testing functionality in nocli #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Goals
This PR separates the driver testing functionality (under sub-command 'uwb') from service testing functionality (under new sub-command 'service'). This is necessary for configuring ranging sessions, because users testing drivers will need to set UCI app config params whereas users testing service code will need to set OOB params.
Technical Details
Test Results
Ran nocli tool for driver testing ('uwb' sub-command) with newest TestClient driver and can successfully invoke necessary IOCTLs for starting a ranging session.
Reviewer Focus
Note: The current code in HandleDriverStartRanging tries to get the app config params after configuring a session. Because the TestClient driver does not support this (yet!), I had to comment these few lines out in order for nocli to work.
Future Work
Checklist
all
compiles cleanly.