Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HandleDriverStartRanging function #161

Merged

Conversation

corbin-phipps
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

This PR adds a new interface function for nocli to start a ranging session for driver testing.

Technical Details

  • Created UwbRangingParameters wrapper struct to contain a session ID and a list of UCI app config parameters.
  • Added new HandleDriverStartRanging function. Unlike HandleStartRanging, this new function takes UwbRangingParameters instead of UwbSessionData.

Test Results

Code builds. Will test further once nocli is reorganized to do driver-specific testing, which will call this new HandleDriverStartRanging function.

Reviewer Focus

Location of UwbRangingParameters struct. Does it make sense where I put it, or should it be moved elsewhere?

Future Work

None.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@corbin-phipps corbin-phipps requested a review from a team as a code owner March 22, 2023 20:05
forwardpointer
forwardpointer previously approved these changes Mar 22, 2023
forwardpointer
forwardpointer previously approved these changes Mar 22, 2023
… github.com:microsoft/nearobject-framework into user/corbinphipps/add-driver-start-ranging-function
@corbin-phipps corbin-phipps merged commit d5ecaaf into develop Mar 23, 2023
@corbin-phipps corbin-phipps deleted the user/corbinphipps/add-driver-start-ranging-function branch March 23, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants