Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UwbApplicationConfigurationParameter in place of IUwbAppConfigurationParameter #153

Merged
merged 5 commits into from
Mar 21, 2023

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Mar 21, 2023

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Replace use of IUwbAppConfigurationParameter with UwbApplicationConfigurationParameter .

Technical Details

  • Replace IUwbAppConfigurationParameter and UwbAppConfigurationParameter with UwbApplicationConfigurationParameter
  • Replace std::vector<IUwbAppConfigurationParameter> with std::vector<UwbApplicationConfigurationParameter>
  • Replace UwbSetAppConfigurationParameters with std::vector<UwbApplicationConfigurationParameter>.
  • Stop compiling source, including tests, containing IUwbAppConfigurationParameter and

Test Results

All unit tests pass on both Linux and Windows.

Reviewer Focus

  • Note that all the code implementing UwbSetAppConfigurationParameters, including neutral <-> DDI conversion functions has been saved and will be harvested to implement the conversion functions for the new types.

Future Work

  • Remove actual source files once code has been harvested for new neutral type implementation.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano marked this pull request as ready for review March 21, 2023 03:11
@abeltrano abeltrano requested a review from a team as a code owner March 21, 2023 03:11
forwardpointer
forwardpointer previously approved these changes Mar 21, 2023
@abeltrano abeltrano merged commit 7e0441a into develop Mar 21, 2023
@abeltrano abeltrano deleted the ifuwbappparam branch March 21, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants