-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add neutral <-> DDI adapter conversion functions for UWB_APP_CONFIG_PARAM #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbin-phipps
suggested changes
Mar 20, 2023
corbin-phipps
previously approved these changes
Mar 20, 2023
forwardpointer
previously approved these changes
Mar 20, 2023
abeltrano
dismissed stale reviews from forwardpointer and corbin-phipps
via
March 21, 2023 02:03
3e1527e
abeltrano
force-pushed
the
uwbappcfgparamconvert
branch
from
March 21, 2023 02:03
2d435b3
to
3e1527e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Goals
Allow
UWB_APP_CONFIG_PARAM
to be converted to and from its corresponding neutral typeUwbApplicationConfigurationParameter
.Technical Details
To
andFrom
neutral <-> DDI adapter conversion functions and unit tests.operator==()
forUwbApplicationConfigurationParameter
.Test Results
Reviewer Focus
UWB_APP_CONFIG_PARAM_TYPE_DEVICE_MAC_ADDRESS
parameter type is correct. It was assumed that the raw address information is provided in theparamValue
array (eg.uint8_t data[2]
anduint8_t data[8]
for short and extended types respectively).Future Work
UWB_APP_CONFIG_PARAM_TYPE_DST_MAC_ADDRESS
is not implemented yet since we haven't yet figured out a way to decode the parameter value because the address type is not specified in the pure UCI encoding. If UwbCx encoded it exactly in this way, we'll have no way of knowing the address type. Probably it makes sense to prepend the array of addresses with the correspondingUWB_APP_CONFIG_PARAM_TYPE_MAC_ADDRESS_MODE
value.UWB_APP_CONFIG_PARAMS
(collection) DDI type needs conversion functions added as well. These will likely be adapter from the existing code @forwardpointer already wrote for the DDI specific wrappers.UWB_APP_CONFIG_PARAM
andUWB_APP_CONFIG_PARAMS
.Checklist
all
compiles cleanly.