Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/corbinphipps/nocli add reset #124

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

corbin-phipps
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

This PR adds the device reset command to the nocli tool

Technical Details

Added "devicereset" sub-command to nocli
Fix the device reset code in UwbDeviceConnector to properly call DeviceIoControl

Test Results

Device reset succeeds on TestClient driver

Reviewer Focus

None.

Future Work

None.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@corbin-phipps corbin-phipps requested a review from a team as a code owner March 7, 2023 21:15
tools/cli/NearObjectCli.cxx Outdated Show resolved Hide resolved
windows/devices/uwb/UwbDeviceConnector.cxx Outdated Show resolved Hide resolved
…li members and getter functions for terminal subcommands
@corbin-phipps corbin-phipps merged commit a4b7b5d into develop Mar 7, 2023
@corbin-phipps corbin-phipps deleted the user/corbinphipps/nocli-add-reset branch March 13, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants