Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-device support to DevicePresenceMonitor #101

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Add multi-device support to DevicePresenceMonitor #101

merged 4 commits into from
Feb 27, 2023

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Feb 27, 2023 •
edited
Loading

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Allow detecting presence changes of multiple distinct devices using a single abstraction.

Technical Details

  • Extend DevicePresenceMonitor to support multiple device GUIDs.
  • Move StartException code from header to source file.
  • Add missing #include guard for guid.hxx.

Test Results

All unit tests pass on both Linux and windows.

Reviewer Focus

None

Future Work

Replace manually rolled presence detection in NearObjectDeviceDiscoveryAgentUwb with this.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner February 27, 2023 20:11
@abeltrano abeltrano merged commit 0c55c53 into develop Feb 27, 2023
@abeltrano abeltrano deleted the devicemonmultiple branch February 27, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano