This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Update CI build matrix for travis and appveyor #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fs-eire
commented
Aug 10, 2017
fs-eire
commented
- Use a fully customized matrix on travis
- Fix CMake missing on ubuntu precise
- Add AppVeyor support
|
@fs-eire, |
daiyip
reviewed
Aug 10, 2017
.travis.yml
Outdated
| - g++-5 | ||
| env: | ||
| - COMPILER_OVERRIDE="CXX=g++-5 CC=gcc-5" | ||
| # Node LTS (6.x) OS X (Yosemite) AppleClang 6.1 |
There was a problem hiding this comment.
AppleClang is actually LLVM.
daiyip
reviewed
Aug 10, 2017
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "napajs", | |||
| "version": "0.1.0", | |||
| "version": "0.1.1", | |||
There was a problem hiding this comment.
Not needed? since we don't change napajs distributables.
daiyip
previously approved these changes
Aug 10, 2017
daiyip
reviewed
Aug 10, 2017
.travis.yml
Outdated
| apt: | ||
| sources: | ||
| - ubuntu-toolchain-r-test | ||
| - george-edison55-precise-backports |
There was a problem hiding this comment.
'ubuntu-toolchain-r-test' is for g++5/g++6
'george-edison55-precise-backports' is for CMake 3.2+
There was a problem hiding this comment.
Can you add comment for these two?
daiyip
suggested changes
Aug 10, 2017
daiyip
reviewed
Aug 10, 2017
| @@ -0,0 +1,26 @@ | |||
| environment: | |||
There was a problem hiding this comment.
please also add appveyor.yml to .npmignore.
daiyip
reviewed
Aug 10, 2017
| @@ -1,3 +1,8 @@ | |||
| [](https://travis-ci.org/Microsoft/napajs) | |||
| [](https://ci.appveyor.com/project/daiyip/napajs) | |||
There was a problem hiding this comment.
Both icons are showing 'build', is it possible to customize the text on the icon?
There was a problem hiding this comment.
Given travis is not customizable, let's keep the two 'build' for now.
daiyip
previously approved these changes
Aug 10, 2017
daiyip
approved these changes
Aug 10, 2017
daiyip
pushed a commit
that referenced
this pull request
Jan 19, 2018
* Update travis customized matrix * Fix default build matrix * Update travis build matrix * Add AppVeyor configuration * remove 2 targets from matrix * Update package version * Update xcode version from 8.2 to 7.3 * Update badges to README.md * Update badges for both travis (Linux/OSX) and appveyor (Windows) * Add comments on apt sources in travis config * add file appveyor.yml to npm ignore list * revert package version to 0.1.0
daiyip
pushed a commit
that referenced
this pull request
Jan 19, 2018
* Update travis customized matrix * Fix default build matrix * Update travis build matrix * Add AppVeyor configuration * remove 2 targets from matrix * Update package version * Update xcode version from 8.2 to 7.3 * Update badges to README.md * Update badges for both travis (Linux/OSX) and appveyor (Windows) * Add comments on apt sources in travis config * add file appveyor.yml to npm ignore list * revert package version to 0.1.0
daiyip
pushed a commit
that referenced
this pull request
Jan 19, 2018
* Update travis customized matrix * Fix default build matrix * Update travis build matrix * Add AppVeyor configuration * remove 2 targets from matrix * Update package version * Update xcode version from 8.2 to 7.3 * Update badges to README.md * Update badges for both travis (Linux/OSX) and appveyor (Windows) * Add comments on apt sources in travis config * add file appveyor.yml to npm ignore list * revert package version to 0.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.