Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and Documentation for PGO #480

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Fixes and Documentation for PGO #480

merged 1 commit into from
Jun 12, 2020

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Jun 8, 2020

Apparently PGO wasn't actually working before, for a couple of reasons. This fixes it for x64 and adds some initial documentation.

@ThadHouse
Copy link
Contributor

Wouldn't we need a PDB per build specification? So we'd need all variations of x86, x64, mitls, schannel and any other build types we want running over PGO?

@nibanks
Copy link
Member Author

nibanks commented Jun 8, 2020

Wouldn't we need a PDB per build specification? So we'd need all variations of x86, x64, mitls, schannel and any other build types we want running over PGO?

Yep. (Assuming I can get this to build). For now, I have it only dynamically picking up PGO if we specify a file for it. As for other TLS configurations, Schannel is the only one we care about, plus it still works if you use the .pgd from Schannel on miTLS builds.

@nibanks
Copy link
Member Author

nibanks commented Jun 8, 2020

Ugg. I have no idea why it's not working now. It was building and running locally just fine. Then I pushed my PR. The PR build broke, then I tried a clean build locally and now it breaks locally too. I'm confused.

@nibanks nibanks merged commit b928444 into master Jun 12, 2020
@nibanks nibanks deleted the nibanks/improve-pgo branch June 12, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants