export platform #4574
Open
export platform #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talregev
force-pushed
the
TalR/export_platform
branch
from
cdc2238
to
36ca8b5
Compare
nibanks
reviewed
Sep 28, 2024
src/bin/CMakeLists.txt
Outdated
| @@ -269,7 +269,7 @@ endif() | |||
| file(GLOB PUBLIC_HEADERS "../inc/*.h" "../inc/*.hpp") | |||
|
|
|||
| if(BUILD_SHARED_LIBS) | |||
| install(TARGETS msquic EXPORT msquic DESTINATION lib) | |||
| install(TARGETS msquic platform inc logging_inc warnings main_binary_link_args OpenSSL OpenSSLQuic EXPORT msquic DESTINATION lib) | |||
There was a problem hiding this comment.
I know. I write that on the description on this PR.
Can you suggest me how to do it more general?
There was a problem hiding this comment.
There is other targets in other tls options?
There was a problem hiding this comment.
I think I can work with this with the ci.
|
This is a draft PR and need more work done for it.
@nibanks can you help me to solve these issue in this PR? |
talregev
force-pushed
the
TalR/export_platform
branch
from
36ca8b5
to
9cbe47d
Compare
talregev
force-pushed
the
TalR/export_platform
branch
from
9cbe47d
to
e615e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For support compile msquic with external msh3 version 0.7.0. It require symbol that found on platform target.
I export these symbols
Other info
This is a draft PR and need more work done for it.
Issue in this PR (maybe more)
fix #4569