Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(react-tag-picker): support TagPicker usage without TagPickerList #32158

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Jul 30, 2024

Previous Behavior

TagPicker right now requires the presence of TagPickerList as a popover to work properly.

New Behavior

  1. ensures that TagPicker can be used without TagPickerList
    • adds property noPopover that can be used to opt-in into this feature
  2. adds stories to showcase how to use this
  3. adds tests to ensure behavior

Related Issue(s)

@bsunderhus bsunderhus self-assigned this Jul 30, 2024
@github-actions github-actions bot added this to the July Project Cycle Q3 2024 milestone Jul 30, 2024
@bsunderhus bsunderhus marked this pull request as ready for review July 30, 2024 08:49
@bsunderhus bsunderhus requested a review from a team as a code owner July 30, 2024 08:49
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 30, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.097 MB
270.908 kB
1.097 MB
270.957 kB
170 B
49 B
react-tag-picker
@fluentui/react-tag-picker - package
182.006 kB
54.721 kB
182.176 kB
54.779 kB
170 B
58 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.14 kB
20.137 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
218 kB
63.151 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
107.387 kB
35.758 kB
🤖 This report was generated against 8cdc1ca044b4c9b7e758c3d8a19688940da3e095

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 30, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 648 665 5000
Button mount 314 308 5000
Field mount 1159 1115 5000
FluentProvider mount 708 708 5000
FluentProviderWithTheme mount 85 80 10
FluentProviderWithTheme virtual-rerender 32 36 10
FluentProviderWithTheme virtual-rerender-with-unmount 76 77 10
MakeStyles mount 868 875 50000
Persona mount 1767 1693 5000
SpinButton mount 1393 1394 5000
SwatchPicker mount 1708 1729 5000

@bsunderhus bsunderhus force-pushed the react-tag-picker/feature--support-usage-without-TagPickerList branch from 66bf521 to 96881dc Compare July 30, 2024 09:07
@bsunderhus bsunderhus marked this pull request as draft July 30, 2024 10:04
@bsunderhus bsunderhus force-pushed the react-tag-picker/feature--support-usage-without-TagPickerList branch 3 times, most recently from 0ae1b59 to 6b998c4 Compare August 1, 2024 10:36
@bsunderhus bsunderhus force-pushed the react-tag-picker/feature--support-usage-without-TagPickerList branch from 6b998c4 to 7cb9ad0 Compare August 1, 2024 11:23
@bsunderhus bsunderhus marked this pull request as ready for review August 1, 2024 11:51
@bsunderhus bsunderhus force-pushed the react-tag-picker/feature--support-usage-without-TagPickerList branch from 7cb9ad0 to a7cb6d6 Compare August 1, 2024 12:06
@bsunderhus bsunderhus force-pushed the react-tag-picker/feature--support-usage-without-TagPickerList branch from a7cb6d6 to 4e1da64 Compare August 9, 2024 08:29
@bsunderhus bsunderhus enabled auto-merge (squash) August 12, 2024 12:16
@bsunderhus bsunderhus merged commit cb6df91 into microsoft:master Aug 12, 2024
19 checks passed
@bsunderhus bsunderhus deleted the react-tag-picker/feature--support-usage-without-TagPickerList branch August 12, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: TagPicker should work without TagPickerList
3 participants