-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(react-tag-picker): support TagPicker usage without TagPickerList #32158
Merged
bsunderhus
merged 3 commits into
microsoft:master
from
bsunderhus:react-tag-picker/feature--support-usage-without-TagPickerList
Aug 12, 2024
Merged
feature(react-tag-picker): support TagPicker usage without TagPickerList #32158
bsunderhus
merged 3 commits into
microsoft:master
from
bsunderhus:react-tag-picker/feature--support-usage-without-TagPickerList
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 648 | 665 | 5000 | |
Button | mount | 314 | 308 | 5000 | |
Field | mount | 1159 | 1115 | 5000 | |
FluentProvider | mount | 708 | 708 | 5000 | |
FluentProviderWithTheme | mount | 85 | 80 | 10 | |
FluentProviderWithTheme | virtual-rerender | 32 | 36 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 77 | 10 | |
MakeStyles | mount | 868 | 875 | 50000 | |
Persona | mount | 1767 | 1693 | 5000 | |
SpinButton | mount | 1393 | 1394 | 5000 | |
SwatchPicker | mount | 1708 | 1729 | 5000 |
bsunderhus
force-pushed
the
react-tag-picker/feature--support-usage-without-TagPickerList
branch
from
July 30, 2024 09:07
66bf521
to
96881dc
Compare
fabricteam
reviewed
Jul 30, 2024
change/@fluentui-react-tag-picker-87e138fe-62c9-4889-8ff8-a472ae227f11.json
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Jul 30, 2024
packages/react-components/react-tag-picker/library/src/components/TagPicker/useTagPicker.ts
Outdated
Show resolved
Hide resolved
bsunderhus
force-pushed
the
react-tag-picker/feature--support-usage-without-TagPickerList
branch
3 times, most recently
from
August 1, 2024 10:36
0ae1b59
to
6b998c4
Compare
github-actions
bot
modified the milestones:
July Project Cycle Q3 2024,
August Project Cycle Q3 2024
Aug 1, 2024
bsunderhus
force-pushed
the
react-tag-picker/feature--support-usage-without-TagPickerList
branch
from
August 1, 2024 11:23
6b998c4
to
7cb9ad0
Compare
bsunderhus
force-pushed
the
react-tag-picker/feature--support-usage-without-TagPickerList
branch
from
August 1, 2024 12:06
7cb9ad0
to
a7cb6d6
Compare
ling1726
reviewed
Aug 9, 2024
packages/react-components/react-tag-picker/library/src/components/TagPicker/useTagPicker.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Aug 9, 2024
packages/react-components/react-tag-picker/stories/src/TagPicker/TagPickerNoPopover.stories.tsx
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Aug 9, 2024
packages/react-components/react-tag-picker/stories/src/TagPicker/TagPickerNoPopover.stories.tsx
Outdated
Show resolved
Hide resolved
bsunderhus
force-pushed
the
react-tag-picker/feature--support-usage-without-TagPickerList
branch
from
August 9, 2024 08:29
a7cb6d6
to
4e1da64
Compare
ling1726
reviewed
Aug 12, 2024
...-components/react-tag-picker/library/src/components/TagPickerControl/useTagPickerControl.tsx
Show resolved
Hide resolved
ling1726
approved these changes
Aug 12, 2024
bsunderhus
deleted the
react-tag-picker/feature--support-usage-without-TagPickerList
branch
August 12, 2024 13:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
TagPicker
right now requires the presence ofTagPickerList
as a popover to work properly.New Behavior
TagPicker
can be used withoutTagPickerList
noPopover
that can be used to opt-in into this featureRelated Issue(s)