Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(.github): resolve due_on UTC time creation issues #31890

Merged
merged 1 commit into from
Jul 1, 2024
Merged

ci(.github): resolve due_on UTC time creation issues #31890

merged 1 commit into from
Jul 1, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 1, 2024 •
edited
Loading

Previous Behavior

milestone action due_on is not proper UTC and keeps filing agains GitHub REST API

New Behavior

due_on is valid UTC

Related Issue(s)

  • Fixes #

@Hotell Hotell added the CI label Jul 1, 2024
@Hotell Hotell force-pushed the ci/gha/milestone/fix-due-on-issue branch from 80a9dad to 8df6864 Compare July 1, 2024 10:52
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 636 650 5000
Button mount 313 315 5000
Field mount 1148 1180 5000
FluentProvider mount 740 730 5000
FluentProviderWithTheme mount 93 95 10
FluentProviderWithTheme virtual-rerender 41 36 10
FluentProviderWithTheme virtual-rerender-with-unmount 86 85 10
MakeStyles mount 884 888 50000
Persona mount 1847 1757 5000
SpinButton mount 1387 1399 5000
SwatchPicker mount 1706 1671 5000

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
LoaderMinimalPerf.default 205 183 1.12:1
ButtonMinimalPerf.default 97 87 1.11:1
RefMinimalPerf.default 123 111 1.11:1
BoxMinimalPerf.default 211 193 1.09:1
ImageMinimalPerf.default 249 229 1.09:1
ChatMinimalPerf.default 452 420 1.08:1
ListMinimalPerf.default 338 314 1.08:1
GridMinimalPerf.default 206 192 1.07:1
InputMinimalPerf.default 562 525 1.07:1
PopupMinimalPerf.default 376 351 1.07:1
IconMinimalPerf.default 419 391 1.07:1
TooltipMinimalPerf.default 1326 1243 1.07:1
AvatarMinimalPerf.default 116 109 1.06:1
ButtonOverridesMissPerf.default 710 670 1.06:1
ChatWithPopoverPerf.default 189 178 1.06:1
LabelMinimalPerf.default 231 217 1.06:1
MenuButtonMinimalPerf.default 997 945 1.06:1
SegmentMinimalPerf.default 202 191 1.06:1
AttachmentMinimalPerf.default 88 84 1.05:1
CarouselMinimalPerf.default 276 262 1.05:1
DropdownManyItemsPerf.default 424 402 1.05:1
MenuMinimalPerf.default 498 474 1.05:1
TableManyItemsPerf.default 1177 1122 1.05:1
HeaderMinimalPerf.default 224 216 1.04:1
RosterPerf.default 1695 1625 1.04:1
SkeletonMinimalPerf.default 214 205 1.04:1
StatusMinimalPerf.default 425 409 1.04:1
TableMinimalPerf.default 242 233 1.04:1
CardMinimalPerf.default 320 312 1.03:1
DialogMinimalPerf.default 467 455 1.03:1
ItemLayoutMinimalPerf.default 747 726 1.03:1
ReactionMinimalPerf.default 216 210 1.03:1
SliderMinimalPerf.default 785 760 1.03:1
AccordionMinimalPerf.default 90 88 1.02:1
AttachmentSlotsPerf.default 670 656 1.02:1
ButtonSlotsPerf.default 311 306 1.02:1
ListNestedPerf.default 338 331 1.02:1
PortalMinimalPerf.default 88 86 1.02:1
TextMinimalPerf.default 207 202 1.02:1
VideoMinimalPerf.default 441 431 1.02:1
AlertMinimalPerf.default 163 161 1.01:1
DatepickerMinimalPerf.default 3719 3696 1.01:1
EmbedMinimalPerf.default 1944 1924 1.01:1
AnimationMinimalPerf.default 313 312 1:1
CheckboxMinimalPerf.default 1149 1148 1:1
DropdownMinimalPerf.default 1464 1468 1:1
HeaderSlotsPerf.default 479 479 1:1
CustomToolbarPrototype.default 1543 1537 1:1
FlexMinimalPerf.default 155 157 0.99:1
LayoutMinimalPerf.default 206 209 0.99:1
ListCommonPerf.default 396 401 0.99:1
ProviderMinimalPerf.default 217 220 0.99:1
ToolbarMinimalPerf.default 554 558 0.99:1
TreeMinimalPerf.default 493 497 0.99:1
ListWith60ListItems.default 364 370 0.98:1
SplitButtonMinimalPerf.default 2344 2387 0.98:1
ChatDuplicateMessagesPerf.default 152 157 0.97:1
ProviderMergeThemesPerf.default 658 677 0.97:1
RadioGroupMinimalPerf.default 258 267 0.97:1
TextAreaMinimalPerf.default 293 301 0.97:1
TreeWith60ListItems.default 84 87 0.97:1
DividerMinimalPerf.default 204 217 0.94:1
FormMinimalPerf.default 220 233 0.94:1

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 648 641 5000
Breadcrumb mount 1684 1673 1000
Checkbox mount 1709 1764 5000
CheckboxBase mount 1511 1496 5000
ChoiceGroup mount 2940 2985 5000
ComboBox mount 674 689 1000
CommandBar mount 6444 6563 1000
ContextualMenu mount 12224 12199 1000
DefaultButton mount 806 802 5000
DetailsRow mount 2194 2199 5000
DetailsRowFast mount 2242 2194 5000
DetailsRowNoStyles mount 2052 2043 5000
Dialog mount 2593 2786 1000
DocumentCardTitle mount 218 214 1000
Dropdown mount 2017 2022 5000
FocusTrapZone mount 1141 1142 5000
FocusZone mount 1075 1073 5000
GroupedList mount 37594 41753 2
GroupedList virtual-rerender 20000 20243 2
GroupedList virtual-rerender-with-unmount 50942 51055 2
GroupedListV2 mount 226 220 2
GroupedListV2 virtual-rerender 201 212 2
GroupedListV2 virtual-rerender-with-unmount 234 243 2
IconButton mount 1118 1124 5000
Label mount 351 345 5000
Layer mount 2774 2770 5000
Link mount 397 402 5000
MenuButton mount 988 993 5000
MessageBar mount 21254 21222 5000
Nav mount 2015 2071 1000
OverflowSet mount 807 786 5000
Panel mount 1829 1812 1000
Persona mount 739 749 1000
Pivot mount 902 909 1000
PrimaryButton mount 913 942 5000
Rating mount 4657 4633 5000
SearchBox mount 920 916 5000
Shimmer mount 1914 1877 5000
Slider mount 1329 1333 5000
SpinButton mount 2971 3005 5000
Spinner mount 394 398 5000
SplitButton mount 1859 1877 5000
Stack mount 422 431 5000
StackWithIntrinsicChildren mount 883 882 5000
StackWithTextChildren mount 2801 2781 5000
SwatchColorPicker mount 6496 6434 5000
TagPicker mount 1483 1469 5000
Text mount 377 381 5000
TextField mount 955 927 5000
ThemeProvider mount 860 830 5000
ThemeProvider virtual-rerender 579 579 5000
ThemeProvider virtual-rerender-with-unmount 1334 1294 5000
Toggle mount 625 630 5000
buttonNative mount 197 191 5000

@Hotell Hotell marked this pull request as ready for review July 1, 2024 11:27
@Hotell Hotell requested a review from a team as a code owner July 1, 2024 11:27
@Hotell Hotell merged commit 114f774 into microsoft:master Jul 1, 2024
20 of 21 checks passed
@Hotell Hotell deleted the ci/gha/milestone/fix-due-on-issue branch July 1, 2024 13:54
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jul 3, 2024
@marcosmoura
Merge branch 'master' into rfc/z-index-handling
1001741 
* master: (45 commits)
  Added unit testcases for sparkline chart. (microsoft#31843)
  release: applying package updates - react v8
  release: applying package updates - web-components
  fix(web-components): fix enterkey interaction on menu (microsoft#31894)
  chore(web-components): expose field to package exports (microsoft#31904)
  fix(web-components): slotted elements within fluent-text-input can't be focused (microsoft#31903)
  fix(web-components): fix menu positioning in firefox (microsoft#31895)
  chore: bump @types/node types to v20 and @tsconfig to v18 (microsoft#31510)
  chore: migrate to nx 19.2.3 (microsoft#31828)
  chore: fix install verdacio command (microsoft#31897)
  fix(scripts-prettier): escape file names that are being passed to prettier bin via shell (microsoft#31889)
  release: applying package updates - react-components
  feat:(docs) Adds pattern doc on Basic Recomposition (microsoft#31861)
  chore:(docs) Archive the wiki 🎉 (microsoft#31202)
  feat:(react-nav-preview) Adds NavDivider implementation (microsoft#31848)
  ci(.github): resolve due_on UTC time creation issues (microsoft#31890)
  release: applying package updates - web-components
  fix: update internal usage of useModalAttributes to use legacyTrapFocus by default (microsoft#31801)
  chore: make utils a package export (microsoft#31865)
  fix: add live region around scroll index update (microsoft#31863)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@marcosmoura marcosmoura marcosmoura approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hotell @fabricteam @marcosmoura